superfluous-else-return (S252)

Fix is sometimes available.

What it does

Checks for else statements with a return statement in the preceeding if block

Why is this bad?

The else statement is not needed as the return statement will always exit the parent function. Removing the else will reduce nesting and make the code more readable.

Example

integer function max(a, b):
  integer, intent(in) :: a, b
  if (a > b) then
    max = a
    return
  else
    max = b
  end if
end function max

Use instead:

integer function max(a, b):
  integer, intent(in) :: a, b
  if (a > b) then
    max = a
    return
  end if
  max = b
end function max